[PATCH] D121585: [InstCombine] Sink instructions with multiple users in a successor block.

Tue Mar 15 08:06:14 PDT 2022

wwei added a comment.

In D121585#3380414 <https://reviews.llvm.org/D121585#3380414>, @nikic wrote:

> In D121585#3380314 <https://reviews.llvm.org/D121585#3380314>, @reames wrote:
>
>> Generally, I'm fine with the direction here.  My sole concern is potential compile time of scanning the entire user list.  (i.e. say we have 100 thousand uses in one block, and the very last one is in another block)   I could see us capping the number of scanned users (we do that a bunch of places) or would want to see some time time numbers showing we don't need to.
>
> Agreed, this needs a cutoff.

I have added an option to limit the number of scanned users, the potential compile time issue can be fixed.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121585/new/

https://reviews.llvm.org/D121585