[PATCH] D121620: [VE] v512|256 f32|64 fneg isel and tests

Simon Moll via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 15 07:40:49 PDT 2022


simoll added inline comments.


================
Comment at: llvm/lib/Target/VE/VVPISelLowering.cpp:86
+                        {Op->getOperand(0), Mask, AVL});
+  if (isVVPBinaryOp(VVPOpcode))
     return CDAG.getNode(VVPOpcode, LegalVecVT,
----------------
kaz7 wrote:
> I'm not sure why it's safe to remove `assert(LegalVecVT.isSimple());` here
The assertion is still there. It's now in line 82.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121620/new/

https://reviews.llvm.org/D121620



More information about the llvm-commits mailing list