[PATCH] D121696: [AMDGPU][MC][NFC] Refactored custom operands handling

Dmitry Preobrazhensky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 15 07:09:20 PDT 2022


dp created this revision.
Herald added subscribers: foad, kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl, arsenm.
Herald added a project: All.
dp requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

The original design of custom operands support assumed that most GPUs
have the same or very similar operand names end encoding. This is
no longer the case. As a result the support code becomes over-complicated
and difficult to maintain.

This change proposes a different design with the following benefits:

- support of aliases;
- support of different encodings of the same operand name depending on GPU;
- identification of defined but unsupported operands.

This is the first part of the change. A patch for sendmsg(...) will be submitted separately.


https://reviews.llvm.org/D121696

Files:
  llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
  llvm/lib/Target/AMDGPU/SIDefines.h
  llvm/lib/Target/AMDGPU/Utils/AMDGPUAsmUtils.cpp
  llvm/lib/Target/AMDGPU/Utils/AMDGPUAsmUtils.h
  llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp
  llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D121696.415417.patch
Type: text/x-patch
Size: 14750 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220315/1e442a6c/attachment.bin>


More information about the llvm-commits mailing list