[PATCH] D121664: [LegalizeTypes][RISCV][WebAssembly] Expand ABS in PromoteIntRes_ABS if it will expand to sra+xor+sub later.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/iabs.ll:22
 ; FIXME: Sign extending the input to the input to the xor isn't needed and
 ; causes an extra srai.
 define i8 @abs8(i8 %x) {
----------------
Update the comment?


================
Comment at: llvm/test/CodeGen/RISCV/iabs.ll:74
 ; FIXME: Sign extending the input to the input to the xor isn't needed and
 ; causes an extra srai.
 define i8 @select_abs8(i8 %x) {
----------------
Update the comment?


================
Comment at: llvm/test/CodeGen/RISCV/iabs.ll:128
 ; FIXME: Sign extending the input to the input to the xor isn't needed and
 ; causes an extra srai.
 define i16 @abs16(i16 %x) {
----------------
Update the comment?


================
Comment at: llvm/test/CodeGen/RISCV/iabs.ll:180
 ; FIXME: Sign extending the input to the input to the xor isn't needed and
 ; causes an extra srai.
 define i16 @select_abs16(i16 %x) {
----------------
Update the comment?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121664/new/

https://reviews.llvm.org/D121664