[PATCH] D121620: [VE] v512|256 f32|64 fneg isel and tests

[Kazushi Marukawa via Phabricator via llvm-commits]

kaz7 added a comment.

Looks fine except these:



================
Comment at: llvm/lib/Target/VE/VVPISelLowering.cpp:85
+    return CDAG.getNode(VVPOpcode, LegalVecVT,
+                        {Op->getOperand(0), Mask, AVL});
+  if (isVVPBinaryOp(VVPOpcode))
----------------
Please follow above clang-format suggestion.


================
Comment at: llvm/lib/Target/VE/VVPISelLowering.cpp:86
+                        {Op->getOperand(0), Mask, AVL});
+  if (isVVPBinaryOp(VVPOpcode))
     return CDAG.getNode(VVPOpcode, LegalVecVT,
----------------
I'm not sure why it's safe to remove `assert(LegalVecVT.isSimple());` here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121620/new/

https://reviews.llvm.org/D121620