[PATCH] D121677: [RISCV] Return Invalid cost in getGatherScatterOpCost instead of crashing for scalable vectors

[Liao Chunyu via Phabricator via llvm-commits]

liaolucy created this revision.
liaolucy added reviewers: craig.topper, kito-cheng, frasercrmck.
Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb, hiraditya.
Herald added a project: All.
liaolucy requested review of this revision.
Herald added subscribers: llvm-commits, alextsao1999, pcwang-thead, eopXD, MaskRay.
Herald added a project: LLVM.

getCommonMaskedMemoryOpCost tries to cast<FixedVectorType> 
on a scalable vector type. Return invalid instead.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D121677

Files:
  llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp
  llvm/test/Transforms/LoopVectorize/RISCV/masked_gather_scatter.ll


Index: llvm/test/Transforms/LoopVectorize/RISCV/masked_gather_scatter.ll
===================================================================
--- llvm/test/Transforms/LoopVectorize/RISCV/masked_gather_scatter.ll
+++ llvm/test/Transforms/LoopVectorize/RISCV/masked_gather_scatter.ll
@@ -2,6 +2,10 @@
 ; RUN: opt < %s -loop-vectorize -mtriple=riscv32 -mattr=+v,+d -riscv-v-vector-bits-min=256 -S | FileCheck %s -check-prefixes=RV32
 ; RUN: opt < %s -loop-vectorize -mtriple=riscv64 -mattr=+v,+d -riscv-v-vector-bits-min=256 -S | FileCheck %s -check-prefixes=RV64
 
+; Check that we don't crash when scalable-vectorization=on.
+; RUN: opt < %s -loop-vectorize -mtriple=riscv32 -mattr=+v,+d -scalable-vectorization=on -S
+; RUN: opt < %s -loop-vectorize -mtriple=riscv64 -mattr=+v,+d -scalable-vectorization=on -S
+
 ; The source code:
 ;
 ;void foo4(double *A, double *B, int *trigger) {
Index: llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp
===================================================================
--- llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp
+++ llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp
@@ -207,8 +207,7 @@
 
   // FIXME: Only supporting fixed vectors for now.
   if (!isa<FixedVectorType>(DataTy))
-    return BaseT::getGatherScatterOpCost(Opcode, DataTy, Ptr, VariableMask,
-                                         Alignment, CostKind, I);
+    return InstructionCost::getInvalid();
 
   auto *VTy = cast<FixedVectorType>(DataTy);
   unsigned NumLoads = VTy->getNumElements();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D121677.415362.patch
Type: text/x-patch
Size: 1513 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220315/d1b3ff11/attachment.bin>