[PATCH] D120230: [SelectOpti][1/4] Setup new select-optimize pass

[Wenlei He via Phabricator via llvm-commits]

wenlei added a comment.

> But in this case, the binary (from BOLT) used to generate profile for the compiler still have cmov, so some loss of profile data is unavoidable. The oscillating issue will mostly be gone though.

We have some special setup where dedicated tier is used for sample profiling for both compiler and BOLT, in that setup we're not profiling post-BOLT binary. It's not the typical prod profiling setup for sample PGO.

OTOH for cmov, since compiler is going to be conservative and deferring that to BOLT, not have compiler profile is okay (just from cmov perspective) as long as BOLT sees the profile from pre-BOLT binary which doesn't do cmov.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120230/new/

https://reviews.llvm.org/D120230