[PATCH] D120861: [XCOFF][1/3] support fileHeader and sectionHeaders in 64-bit XCOFF.

Esme Yi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 14 20:51:16 PDT 2022


Esme added inline comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:1039
   // Calculate the RawPointer value for each section.
-  uint64_t RawPointer = XCOFF::FileHeaderSize32 + auxiliaryHeaderSize() +
-                        SectionCount * XCOFF::SectionHeaderSize32;
+  uint64_t RawPointer = is64Bit() ? (XCOFF::FileHeaderSize64 +
+                                     SectionCount * XCOFF::SectionHeaderSize64)
----------------
DiggerLin wrote:
>  why there is no "+auxiliaryHeaderSize()  " 
As I understand, we don't need to support auxiliary header in ObjectWriter?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120861/new/

https://reviews.llvm.org/D120861



More information about the llvm-commits mailing list