[PATCH] D121272: [CaptureTracking][NFCI] Expose capture tracking logic

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 14 14:58:41 PDT 2022


jdoerfert added inline comments.


================
Comment at: llvm/include/llvm/Analysis/CaptureTracking.h:113
+    MAY_CAPTURE,
+    PASSTHROUGH,
+  };
----------------
sidorovd wrote:
> Hi, while PASSTHROUGH seems to be a good name for the enum value, it so happened, that it is also a macro defined in wingdi.h (which is included in windows.h). Can we consider renaming it or we should guard/undef the macro in the downstream?
Rename it here and in all use sites. I guess we could add UCK_ ad prefix, or make it something like `USER_MAY_CAPTURE`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121272/new/

https://reviews.llvm.org/D121272



More information about the llvm-commits mailing list