[PATCH] D116462: [SPIRV 3/6] Add MC layer, object file support and InstPrinter

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/SPIRV/MCTargetDesc/SPIRVInstPrinter.cpp:101
+    if (Op.isReg()) {
+      O << "%" << (Register::virtReg2Index(Op.getReg()) + 1);
+    } else if (Op.isImm()) {
----------------
Single quotes


================
Comment at: llvm/lib/Target/SPIRV/MCTargetDesc/SPIRVInstPrinter.cpp:107
+    } else {
+      assert(Op.isExpr() && "Expected an expression");
+      printExpr(Op.getExpr(), O);
----------------
else if and use llvm_unreachable?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116462/new/

https://reviews.llvm.org/D116462