[PATCH] D121638: [lld-macho] Avoid using bump-alloc in TrieBuider

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 14 14:17:37 PDT 2022


int3 added inline comments.


================
Comment at: lld/MachO/ExportTrie.h:25
 public:
+  explicit ~TrieBuilder();
   void setImageBase(uint64_t addr) { imageBase = addr; }
----------------
int3 wrote:
> do we need this?
sorry, I misread this as a ctor instead of a dtor. But I think `explicit` only applies to ctors, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121638/new/

https://reviews.llvm.org/D121638



More information about the llvm-commits mailing list