[PATCH] D121630: [IRLinker] make IRLinker::AddLazyFor optional (llvm::unique_function). NFC

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 14 14:06:00 PDT 2022


nickdesaulniers added a comment.

In D121630#3380437 <https://reviews.llvm.org/D121630#3380437>, @dexonsmith wrote:

> LGTM. I have a slight preference for `llvm::unique_function<>` instead of `Optional<std::function<>>`, but if you have a reason to prefer what's in the patch that's fine with me.

TIL; was using `llvm::Optional` out of naivete of `llvm::unique_function`. Thanks for the recommendation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121630/new/

https://reviews.llvm.org/D121630



More information about the llvm-commits mailing list