[PATCH] D120574: [dsymutil] Apply relocations present in Swift reflection sections
Adrian Prantl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 14 14:00:04 PDT 2022
aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/include/llvm/Object/MachO.h:394
+ static bool isMachOPairedReloc(uint64_t RelocType, uint64_t Arch);
+
----------------
Doxygen Comment?
================
Comment at: llvm/include/llvm/Object/MachO.h:395
+ static bool isMachOPairedReloc(uint64_t RelocType, uint64_t Arch);
+
void moveSymbolNext(DataRefImpl &Symb) const override;
----------------
I know this would be a little redundant, but this function should probably have a unit test, since it's entirely self-contained.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120574/new/
https://reviews.llvm.org/D120574
More information about the llvm-commits
mailing list