[PATCH] D121573: [BOLT][NFC] Use X86 mnemonic tables

Amir Ayupov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 14 13:09:37 PDT 2022


Amir added inline comments.


================
Comment at: bolt/lib/Target/X86/X86MCPlusBuilder.cpp:65
-  case X86::ADD16ri8:
-  case X86::ADD16ri8_DB:
-  case X86::ADD16ri_DB:
----------------
craig.topper wrote:
> Was it important that the _DB instructions were in here before. They don't have mnemonics so the new patch won't have them as adds.
My understanding is that _DB instructions can only be lowered into, but can't be produced by a disassembler, so no, it shouldn't matter for BOLT that these are left out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121573/new/

https://reviews.llvm.org/D121573



More information about the llvm-commits mailing list