[PATCH] D121121: [SLP]Do not schedule instructions with constants/argument/phi operands and external users.

[Vasileios Porpodas via Phabricator via llvm-commits]

vporpo accepted this revision.
vporpo added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:811
+/// in the current basic block.
+static bool doesNotNeedToSchedule(Value *V) {
+  return areAllOperandsNonInsts(V) && isUsedOutsideBlock(V);
----------------
nit: perhaps rename it to `doesNotNeedToBeScheduled`? If it was a member function of the scheduler I think it would sound fine being called like `scheduler.doesNotNeedToSchedule(V)`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121121/new/

https://reviews.llvm.org/D121121