[PATCH] D121311: [IROutliner] Ignore Regions where part of an outlined phi nodes incoming block is included, but the final branch instruction is not

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 14 11:03:15 PDT 2022


paquette added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:286
+      // case, the branch from this block must also be outlined to be valid.
+      IBlock = PN->getIncomingBlock(i);
+      if (IBlock == EndBB && EndBBTermAndBackInstDifferent)
----------------
Pull this above the `if (!BBSet.contains(PN->getIncomingBlock(i)))`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121311/new/

https://reviews.llvm.org/D121311



More information about the llvm-commits mailing list