[llvm] 2f5c408 - [WebAssembly] Remove unused method from WebAssemblyTargetStreamer. NFC

Sam Clegg via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 14 10:17:06 PDT 2022


Author: Sam Clegg
Date: 2022-03-14T10:16:56-07:00
New Revision: 2f5c4083eab5c6048de22d5daa69944aae15159a

URL: https://github.com/llvm/llvm-project/commit/2f5c4083eab5c6048de22d5daa69944aae15159a
DIFF: https://github.com/llvm/llvm-project/commit/2f5c4083eab5c6048de22d5daa69944aae15159a.diff

LOG: [WebAssembly] Remove unused method from WebAssemblyTargetStreamer. NFC

Differential Revision: https://reviews.llvm.org/D121538

Added: 
    

Modified: 
    llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyTargetStreamer.cpp
    llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyTargetStreamer.h

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyTargetStreamer.cpp b/llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyTargetStreamer.cpp
index 397b9b0ee9dad..2da219d54c73d 100644
--- a/llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyTargetStreamer.cpp
+++ b/llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyTargetStreamer.cpp
@@ -58,8 +58,6 @@ void WebAssemblyTargetAsmStreamer::emitLocal(ArrayRef<wasm::ValType> Types) {
   }
 }
 
-void WebAssemblyTargetAsmStreamer::emitEndFunc() { OS << "\t.endfunc\n"; }
-
 void WebAssemblyTargetAsmStreamer::emitFunctionType(const MCSymbolWasm *Sym) {
   assert(Sym->isFunction());
   OS << "\t.functype\t" << Sym->getName() << " ";
@@ -136,10 +134,6 @@ void WebAssemblyTargetWasmStreamer::emitLocal(ArrayRef<wasm::ValType> Types) {
   }
 }
 
-void WebAssemblyTargetWasmStreamer::emitEndFunc() {
-  llvm_unreachable(".end_func is not needed for direct wasm output");
-}
-
 void WebAssemblyTargetWasmStreamer::emitIndIdx(const MCExpr *Value) {
   llvm_unreachable(".indidx encoding not yet implemented");
 }

diff  --git a/llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyTargetStreamer.h b/llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyTargetStreamer.h
index c0ad63c8dd509..522f6356c28b6 100644
--- a/llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyTargetStreamer.h
+++ b/llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyTargetStreamer.h
@@ -32,8 +32,6 @@ class WebAssemblyTargetStreamer : public MCTargetStreamer {
 
   /// .local
   virtual void emitLocal(ArrayRef<wasm::ValType> Types) = 0;
-  /// .endfunc
-  virtual void emitEndFunc() = 0;
   /// .functype
   virtual void emitFunctionType(const MCSymbolWasm *Sym) = 0;
   /// .indidx
@@ -66,7 +64,6 @@ class WebAssemblyTargetAsmStreamer final : public WebAssemblyTargetStreamer {
   WebAssemblyTargetAsmStreamer(MCStreamer &S, formatted_raw_ostream &OS);
 
   void emitLocal(ArrayRef<wasm::ValType> Types) override;
-  void emitEndFunc() override;
   void emitFunctionType(const MCSymbolWasm *Sym) override;
   void emitIndIdx(const MCExpr *Value) override;
   void emitGlobalType(const MCSymbolWasm *Sym) override;
@@ -83,7 +80,6 @@ class WebAssemblyTargetWasmStreamer final : public WebAssemblyTargetStreamer {
   explicit WebAssemblyTargetWasmStreamer(MCStreamer &S);
 
   void emitLocal(ArrayRef<wasm::ValType> Types) override;
-  void emitEndFunc() override;
   void emitFunctionType(const MCSymbolWasm *Sym) override {}
   void emitIndIdx(const MCExpr *Value) override;
   void emitGlobalType(const MCSymbolWasm *Sym) override {}
@@ -104,7 +100,6 @@ class WebAssemblyTargetNullStreamer final : public WebAssemblyTargetStreamer {
       : WebAssemblyTargetStreamer(S) {}
 
   void emitLocal(ArrayRef<wasm::ValType>) override {}
-  void emitEndFunc() override {}
   void emitFunctionType(const MCSymbolWasm *) override {}
   void emitIndIdx(const MCExpr *) override {}
   void emitGlobalType(const MCSymbolWasm *) override {}


        


More information about the llvm-commits mailing list