[PATCH] D121167: [NewPM] Actually recompute GlobalsAA before module optimization pipeline

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 14 09:32:13 PDT 2022


aeubanks added a comment.

In D121167#3372709 <https://reviews.llvm.org/D121167#3372709>, @fhahn wrote:

> LGTM, thanks.
>
>> Yes that's right, just recomputing GlobalsAA won't cause AAManager to pick it up. Here we're still using the same GlobalsAA instance that the AAManager already has a reference to.
>
> I'll look into adding GlobalsAA into AAManager without invalidating anything.
>
> Should this be handled separately?

Yes, it requires different mechanisms than this patch


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121167/new/

https://reviews.llvm.org/D121167



More information about the llvm-commits mailing list