[PATCH] D121180: [AArch64] Perform last active true vector combine

Paul Walker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 14 06:38:06 PDT 2022


paulwalker-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:14411
+
+  SDValue SetCC = N->getOperand(0);
+  EVT OpVT = SetCC.getValueType();
----------------
Should this have the same `SetCC.getOpcode() == ISD::SETCC` restriction as `performFirstTrueTestVectorCombine` for the same reasons? If not then can you rename the variable.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121180/new/

https://reviews.llvm.org/D121180



More information about the llvm-commits mailing list