[PATCH] D121292: [VP] Add vp.fcmp comparison intrinsic and docs

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck added a comment.

In D121292#3375539 <https://reviews.llvm.org/D121292#3375539>, @simoll wrote:

> I agree, it's verbose and there is no other comparison operators in sight.. but having macros in VPIntrinsics.def is the canonical form, so i am still in favor of going the `VP_PROPERTY_CMP` route.
> +1 for `VPCmp`. If needed that can be specialized later.

Fair enough, that makes sense. I've added `VP_PROPERTY_CMP` and am using it for the CC operand position and true/false about whether it takes FP condition codes. Just so we're not partially relying on a property and partially on explicit opcode checks when integer comparisons come around.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121292/new/

https://reviews.llvm.org/D121292