[PATCH] D120638: [llvm-objcopy] --weaken-symbol/--weaken: weaken STB_GNU_UNIQUE symbols

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 13 23:21:22 PDT 2022


jhenderson added a comment.

In D120638#3375799 <https://reviews.llvm.org/D120638#3375799>, @MaskRay wrote:

> In D120638#3348436 <https://reviews.llvm.org/D120638#3348436>, @jhenderson wrote:
>
>> Looks good iff the GNU side are happy with the behaviour change.
>
> They haven't responded yet: https://sourceware.org/pipermail/binutils/2022-March/119961.html
> I am inclined to land this instead of keep waiting.

I'm not. llvm-objcopy promises to match the behaviour of GNU objcopy except for where he GNU behaviour doesn't make sense. This doesn't fall into that exception, in my opinion (yes, what you're doing is not unreasonable, but the old behaviour is not nonsense).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120638/new/

https://reviews.llvm.org/D120638



More information about the llvm-commits mailing list