[PATCH] D121568: Add cmake_parse_arguments() to `tablegen()` CMake function

[Stella Laurenzo via Phabricator via llvm-commits]

stellaraccident accepted this revision.
stellaraccident added a comment.
This revision is now accepted and ready to land.

Thanks!



================
Comment at: llvm/cmake/modules/TableGen.cmake:95
   get_directory_property(tblgen_includes INCLUDE_DIRECTORIES)
+  list(APPEND tblgen_includes ${ARG_EXTRA_INCLUDES})
   list(TRANSFORM tblgen_includes PREPEND -I)
----------------
Can be for a followup, but I have found this transform to be fragile when empty items are present (the resultant error is quite bad since the "-I" eats the next argument, which then causes it to think the following argument is a source file). It was possible to have this happen before, but now that it is "user serviceable", we should be more defensive.

Can you add (before the TRANSFORM ... PREPEND):

```
list(REMOTE_ITEM tblgen_includes "")
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121568/new/

https://reviews.llvm.org/D121568