[PATCH] D121549: Define ABI breaking class members correctly

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 13 10:56:50 PDT 2022


mehdi_amini added inline comments.


================
Comment at: mlir/lib/Target/SPIRV/Deserialization/Deserializer.h:601
 
+  // TODO: place logger under #if LLVM_ENABLE_ABI_BREAKING_CHECKS
 #ifndef NDEBUG
----------------
This is a private header (you're in the `lib` directory and not in the `include` directory)

Same for the SystemZ one above I believe.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121549/new/

https://reviews.llvm.org/D121549



More information about the llvm-commits mailing list