[PATCH] D121531: [ELF] Implement --build-id={md5, sha1} with truncated BLAKE3

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 12 16:33:30 PST 2022


MaskRay marked an inline comment as done.
MaskRay added a comment.

In D121531#3377547 <https://reviews.llvm.org/D121531#3377547>, @joerg wrote:

> I would find it quite surprising to find two binaries produced with the same command line now resulting in different build-ids, if that is the only difference. Especially when the cryptographic hash function is explicitly set.

lld built at different commits don't guarantee a binary gets hashed with the same way.
When a tree hash style parallelism was added, the hash obviously changed.
The stability/determinism is only related to lld built at the same commit.

This is like we don't guarantee output may be the same with lld different at different commits.
The hash changes very infrequently, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121531/new/

https://reviews.llvm.org/D121531



More information about the llvm-commits mailing list