[PATCH] D121508: [MCA] Moving six instruction flags out of InstrDesc and into InstructionBase.
Patrick Holland via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Mar 12 11:46:44 PST 2022
holland11 added a comment.
In D121508#3376937 <https://reviews.llvm.org/D121508#3376937>, @andreadb wrote:
> Just a couple of minor comments. Otherwise, patch looks good to me.
>
> Thanks!
I'd never learned about that bitfield declaration pattern before. Just googled it and it makes a lot of sense. I've seen that pattern around mca's codebase, but I always assumed it was just an alternative way to give default values. Thanks for the suggestions!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121508/new/
https://reviews.llvm.org/D121508
More information about the llvm-commits
mailing list