[PATCH] D121402: [X86][NFC] Move table from getRelaxedOpcodeArith into its own class

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86InstrRelaxTables.cpp:138
+
+  void addTableEntry(const X86InstrRelaxTableEntry &Entry) {
+    Table.push_back({Entry.DstOp, Entry.KeyOp});
----------------
skan wrote:
> craig.topper wrote:
> > Does this method provide much value versus calling push_back directly in the loop?
> https://llvm.org/doxygen/classllvm_1_1ManagedStatic.html I think the ShortTable is seldom used, AFAIK, it is used only bolt. So we avoid the construction at most of the time.
That comment was directed at the `AddTableEntry` method from previous patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121402/new/

https://reviews.llvm.org/D121402