[PATCH] D121402: [X86][NFC] Move table from getRelaxedOpcodeArith into its own class

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 11 22:13:20 PST 2022


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86InstrRelaxTables.cpp:138
+
+  void addTableEntry(const X86InstrRelaxTableEntry &Entry) {
+    Table.push_back({Entry.DstOp, Entry.KeyOp});
----------------
Does this method provide much value versus calling push_back directly in the loop?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121402/new/

https://reviews.llvm.org/D121402



More information about the llvm-commits mailing list