[PATCH] D116462: [SPIRV 3/6] Add MC layer, object file support and InstPrinter

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 11 20:13:06 PST 2022


MaskRay requested changes to this revision.
MaskRay added a comment.
This revision now requires changes to proceed.

If you use a recent Clang to build llvm-project, there are several warnings:

  llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:4859:11: warning: enumeration value 'SPIRV' not handled in switch [-Wswitch]
  llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2106:11: warning: enumeration value 'SPIRV' not handled in switch [-Wswitch]
  llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp:6368:11: warning: enumeration value 'IsSPIRV' not handled in switch [-Wswitch]
  
  # I did not check whether this was due to a previous patch
  llvm/lib/Target/SPIRV/MCTargetDesc/SPIRVBaseInfo.cpp:532:3: warning: default label in switch which covers all enumeration values [-Wcovered-switch-default]

Does SPIRV need TargetLoweringObjectFileSPIRV? When GOFF was added in D106380 <https://reviews.llvm.org/D106380>, there was a test in test/CodeGen/SystemZ


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116462/new/

https://reviews.llvm.org/D116462



More information about the llvm-commits mailing list