[PATCH] D121421: [VFS] Add dump to the whole FileSystem hierarchy
Ben Barham via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 11 14:12:45 PST 2022
bnbarham added a comment.
In D121421#3376132 <https://reviews.llvm.org/D121421#3376132>, @dexonsmith wrote:
> This is awesome! Maybe eventually we'll want more details about some of these but this is enough to be useful.
>
> A few comments inline, but besides the rename I suggested from dump to print, up to you whether to address now or later. It'd also be nice to unit test `print()` for OverlayFileSystem; in which case you might want the extra flags I suggest inline.
Thanks for the review! All great suggestions that I think would be worth getting in now - they shouldn't take too long.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121421/new/
https://reviews.llvm.org/D121421
More information about the llvm-commits
mailing list