[llvm] a7ac200 - [MC] Remove unneeded zlib opt-out for .debug_frame

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 11 13:32:29 PST 2022


Author: Fangrui Song
Date: 2022-03-11T13:32:24-08:00
New Revision: a7ac200fd0c509ca89a294c5f08e456a081ceac0

URL: https://github.com/llvm/llvm-project/commit/a7ac200fd0c509ca89a294c5f08e456a081ceac0
DIFF: https://github.com/llvm/llvm-project/commit/a7ac200fd0c509ca89a294c5f08e456a081ceac0.diff

LOG: [MC] Remove unneeded zlib opt-out for .debug_frame

The opt-out from rL236267 (2015) is untested and seems no longer needed (or not
needed when rL236267 was committed): there is nothing special with uncompressed
alignment. This brings us in line with GCC which compresses .debug_frame .

Checked that -g -fno-asynchronous-unwind-tables + objcopy
--decompress-debug-sections output is identical to -g
-fno-asynchronous-unwind-tables -gz + objcopy --decompress-debug-sections
output.

Added: 
    

Modified: 
    llvm/lib/MC/ELFObjectWriter.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/MC/ELFObjectWriter.cpp b/llvm/lib/MC/ELFObjectWriter.cpp
index 5b137e4db3dd2..abcd3bb2b8496 100644
--- a/llvm/lib/MC/ELFObjectWriter.cpp
+++ b/llvm/lib/MC/ELFObjectWriter.cpp
@@ -848,13 +848,9 @@ void ELFWriter::writeSectionData(const MCAssembler &Asm, MCSection &Sec,
   auto &MC = Asm.getContext();
   const auto &MAI = MC.getAsmInfo();
 
-  // Compressing debug_frame requires handling alignment fragments which is
-  // more work (possibly generalizing MCAssembler.cpp:writeFragment to allow
-  // for writing to arbitrary buffers) for little benefit.
   bool CompressionEnabled =
       MAI->compressDebugSections() != DebugCompressionType::None;
-  if (!CompressionEnabled || !SectionName.startswith(".debug_") ||
-      SectionName == ".debug_frame") {
+  if (!CompressionEnabled || !SectionName.startswith(".debug_")) {
     Asm.writeSectionData(W.OS, &Section, Layout);
     return;
   }


        


More information about the llvm-commits mailing list