[PATCH] D115653: [DAG]Introduce llvm::processShuffleMasks and use it for shuffles in DAG Type Legalizer.

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 11 11:21:54 PST 2022


ABataev added a comment.

In D115653#3375729 <https://reviews.llvm.org/D115653#3375729>, @spatel wrote:

> In D115653#3375682 <https://reviews.llvm.org/D115653#3375682>, @ABataev wrote:
>
>> If I understood your question correctly, NoInputAction, SingleInputAction and ManyInputsAction params are exactly for this.
>
> I'm wondering when the NoInput or SingleInput behavior would be something other than return of undef or a unary shuffle. If we never diverge from that, then we don't need to complicate the interface with those parameters?

The idea is to unify interface not only here, but also use the same function for the cost of shuffles. Generally speaking, I can merge these actions into single one, but just would like to simplify the functionality of the actions for the user.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115653/new/

https://reviews.llvm.org/D115653



More information about the llvm-commits mailing list