[PATCH] D120664: [VP] IR expansion pass for VP gather and scatter

[Simon Moll via Phabricator via llvm-commits]

simoll added inline comments.
Herald added a project: All.


================
Comment at: llvm/lib/CodeGen/ExpandVectorPredication.cpp:432
+    NewMemoryInst = Builder.CreateMaskedScatter(
+        DataParam, PtrParam, AlignOpt.valueOrOne(), MaskParam);
+    break;
----------------
Not sure about `valueOrOne()` here... can we assume alignment to element size? Does the data layout tell us something here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120664/new/

https://reviews.llvm.org/D120664