[PATCH] D121460: [FunctionAttrs] Replace MemoryAccessKind with FMRB.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked 3 inline comments as done.
fhahn added inline comments.


================
Comment at: llvm/include/llvm/Transforms/IPO/FunctionAttrs.h:23
 #include "llvm/IR/PassManager.h"
+#include <cstdint>
 
----------------
nikic wrote:
> Why?
leftover, removed


================
Comment at: llvm/lib/Transforms/IPO/FunctionAttrs.cpp:133-140
     if (AliasAnalysis::onlyReadsMemory(MRB))
-      return MAK_ReadOnly;
+      return FMRB_OnlyReadsMemory;
 
     if (AliasAnalysis::onlyWritesMemory(MRB))
-      return MAK_WriteOnly;
+      return FMRB_OnlyWritesMemory;
 
     // Conservatively assume it reads and writes to memory.
----------------
nikic wrote:
> I think you can just `return MRB` in this whole branch.
updated


================
Comment at: llvm/lib/Transforms/IPO/FunctionAttrs.cpp:196
 
+        AccessesNonArgs |= IsNonArgumentObject(Loc.Ptr);
+
----------------
nikic wrote:
> This is presumably not supposed to be part of //this// patch, as it's not used?
Yes, that made it in by accident. Removed


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121460/new/

https://reviews.llvm.org/D121460