[PATCH] D121460: [FunctionAttrs] Turn MemoryAccessKind into class (NFC).

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 11 08:42:03 PST 2022


fhahn updated this revision to Diff 414671.
fhahn added a comment.

In D121460#3375133 <https://reviews.llvm.org/D121460#3375133>, @nikic wrote:

> Hm, could we maybe replace MemoryAccessKind with FunctionModRefBehavior? That's basically ArgMemOnly + InaccessibleMemOnly + ModRef, which seems like where we'll want to end up here as well?

Yeah that seems to work and overall less work. I updated this patch to replace MemoryAccessKind with FunctionModRefBehavior.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121460/new/

https://reviews.llvm.org/D121460

Files:
  llvm/include/llvm/Transforms/IPO/FunctionAttrs.h
  llvm/lib/Transforms/IPO/FunctionAttrs.cpp
  llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp
  llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D121460.414671.patch
Type: text/x-patch
Size: 6541 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220311/3b1cf7a8/attachment.bin>


More information about the llvm-commits mailing list