[PATCH] D120827: [VPlan] Helper to check if a recipe only uses scalar values of op.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked 4 inline comments as done.
fhahn added a comment.

In D120827#3372613 <https://reviews.llvm.org/D120827#3372613>, @Ayal wrote:

> Looks good to me, with some last minor nits.
> Can drop 'only' also from title.

Thanks, I'll address them in the committed version.

> Specifying VPScalarIVStepsRecipe::onlyFirstLaneUsed() could be committed separately, it belongs to previous patches introducing VPScalarIVStepsRecipe and/or onlyFirstLaneUsed().

Will do!



================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:1921
+  /// Returns true if the recipe only uses the first lane of operand \p Op.
+  /// Conservatively returns false.
+  bool onlyFirstLaneUsed(const VPValue *Op) const override {
----------------
Ayal wrote:
> drop "  /// Conservatively returns false."
Will do ,thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120827/new/

https://reviews.llvm.org/D120827