[PATCH] D121452: [VPlan] Avoid scalarization for scalable vectors.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/scalable-avoid-scalarization.ll:5
+
+; CHECK-NOT: Assertion {{.*}} "Can't scalarize a scalable vector"' failed
+
----------------
Does this fail without the change or does this need `2>&1`?


================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/scalable-avoid-scalarization.ll:19
+
+L.LB19_336:                                       ; preds = %L.LB19_336, %L.entry
+  %indvars.iv = phi i32 [ %indvars.iv.next, %L.LB19_336 ], [ %0, %L.entry ]
----------------
could use some better names


================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/scalable-avoid-scalarization.ll:23
+  %1 = getelementptr i64, i64* %a, i32 %indvars.iv
+  %2 = bitcast i64* %1 to double*
+  %3 = load double, double* %2, align 8
----------------
Is the bit cast needed or could this just load `i64`? It would also be good to add make sure the load is not dead in the loop.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121452/new/

https://reviews.llvm.org/D121452