[PATCH] D121418: [AMDGPU] Add symbolic names for gfx940 HWREGs

[Dmitry Preobrazhensky via Phabricator via llvm-commits]

dp added a comment.

Overall looks fine.
I've already refactored handling of hwreg and sendmsg which simplifies the code significantly. But I have to update my patch with GFX940 changes before sending it for review.



================
Comment at: llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h:615-616
 
 LLVM_READNONE
-bool isValidHwreg(int64_t Id, const MCSubtargetInfo &STI);
+bool isValidHwreg(int64_t Id, const MCSubtargetInfo &STI, StringRef Name);
 
----------------
I'm not sure LLVM_READNONE could be used here because the function reads non-constant memory pointed to by Name. Should the attribute be replaced with LLVM_READONLY?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121418/new/

https://reviews.llvm.org/D121418