[PATCH] D121411: [AMDGPU] Support v_mov_b64 in dpp combine

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 11 02:40:13 PST 2022


foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

Looks OK.

As an alternative, maybe we could remove V_MOV_B64_DPP_PSEUDO, use the pseudo V_MOV_B64_dpp on all targets, and expand it post-ra only on targets that don't support it?



================
Comment at: llvm/lib/Target/AMDGPU/GCNDPPCombine.cpp:169
   case AMDGPU::COPY:
   case AMDGPU::V_MOV_B32_e32:
+  case AMDGPU::V_MOV_B64_PSEUDO:
----------------
I wonder why we don't include V_MOV_B32_e64? Maybe we never use it for an immediate copy?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121411/new/

https://reviews.llvm.org/D121411



More information about the llvm-commits mailing list