[PATCH] D121452: [SVE][VPlan] Avoid collecting scalars for SVE

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added a comment.

Hi @malharJ, thanks for this fix! I believe this is doing the right thing, because for scalable vectors an instruction should either be considered uniform after vectorization, or it shouldn't be considered scalar.

Can you remove any references to `SVE` and instead replace it with `scalable vectors` in the commit message and title. This patch isn't specific to AArch64 SVE, but rather scalable vectors in general.



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:4639-4641
+  // This avoids any chances of creating a REPLICATE recipe during planning
+  // since that would result in generation of scalarized code during execution,
+  // which is not supported for SVE.
----------------
nit: `s/during planning [...] for SVE./for scalable vectors./`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121452/new/

https://reviews.llvm.org/D121452