[PATCH] D120230: [SelectOpti][1/4] Setup new select-optimize pass

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

In D120230#3374100 <https://reviews.llvm.org/D120230#3374100>, @davidxl wrote:

> The patch looks good to me. Adding Teresa to look at the pass ordering change.

Do you mean the placement of the new pass? Because I don't see any changes to ordering other than the addition.

One comment about the patch is that it would be good to remove the llvm_unreachable, and test for the pass in one of the pass ordering tests. E.g. llvm/test/CodeGen/X86/opt-pipeline.ll (there are similar ones for other archs too).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120230/new/

https://reviews.llvm.org/D120230