[PATCH] D121351: [lld-macho][nfc] Allow Defined symbols to be placed in binding sections

[Di Mo via Phabricator via llvm-commits]

modimo accepted this revision.
modimo added a comment.
This revision is now accepted and ready to land.

LGTM aside from one comment. Thanks for splitting this out!



================
Comment at: lld/MachO/SyntheticSections.cpp:423
+    return ordinalForDylibSymbol(*dysym);
+  assert(cast<Defined>(&sym)->interposable);
+  return BIND_SPECIAL_DYLIB_FLAT_LOOKUP;
----------------
`interposable` hasn't been defined yet here so the builds are failing. Should be fine to move this to D119294 since this'll be committed as a stack.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121351/new/

https://reviews.llvm.org/D121351