[PATCH] D119294: [lld-macho] -flat_namespace for dylibs should make all externs interposable

[Di Mo via Phabricator via llvm-commits]

modimo added inline comments.


================
Comment at: lld/MachO/SyntheticSections.cpp:422
 
+static int16_t ordinalForSymbol(const Symbol &sym) {
+  if (const auto *dysym = dyn_cast<DylibSymbol>(&sym))
----------------
int3 wrote:
> modimo wrote:
> > >Note that the non-lazy binding and lazy binding sections now have to accommodate both DylibSymbols and (interposable) Defined symbols.
> > 
> > Aside from s/`DylibSymbol`/`Symbol`/g is the only other change to support this here?
> > 
> > Also, would recommended factoring out the s/`DylibSymbol`/`Symbol`/g change to a separate diff as a parent to make it easier to see what files have logic changes in them 
> Pretty much yeah. I'll split out the NFC changes 👍
Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119294/new/

https://reviews.llvm.org/D119294