[PATCH] D121398: Return an error when dsymutil might produce an invalid mach-o file.

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

A little bike shedding about the error but otherwise this LGTM



================
Comment at: llvm/tools/dsymutil/MachOUtils.cpp:325
+      if (FileOffset > UINT32_MAX)
+        return error("section " + Sec->getName() + "'s file offset exceeds 4GB and will produce an invalid mach-o file");
     }
----------------
aprantl wrote:
> what does error() return?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121398/new/

https://reviews.llvm.org/D121398