[PATCH] D121396: Fix dsymutil to handle universal files that exceed 4GB.

walter erquinigo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 10 11:32:47 PST 2022


wallace accepted this revision.
wallace added a comment.
This revision is now accepted and ready to land.

Lgtm



================
Comment at: llvm/tools/dsymutil/dsymutil.cpp:747
+          Options.LinkOpts.VFS->status(OutputLocationOrErr->DWARFFile);
+      if (stat) {
+        if (stat->getSize() > std::numeric_limits<uint32_t>::max()) {
----------------
You can merge this if and the next one to reduce the indentation


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121396/new/

https://reviews.llvm.org/D121396



More information about the llvm-commits mailing list