[PATCH] D120894: [AArch64][SVE]Make better use of gather/scatter when inside a loop body

Caroline via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 10 07:22:55 PST 2022


CarolineConcatto marked 4 inline comments as done.
CarolineConcatto added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:12313
+        for (uint64_t i = 0; i < I->getNumOperands(); i++) {
+          if (isSplatShuffle(I->getOperand(i))) {
+            Ops.push_back(
----------------
david-arm wrote:
> I think you might be able to simplify this a little with this:
> 
>   auto OpI = I->getOperand(i);
>   if (isSplatShuffle(OpI))
>     Ops.push_back(&cast<Instruction>(OpI)->getOperandUse(0));
>   Ops.push_back(&I->getOperandUse(i));
I changed a bit the code, as asked by Sander.
So now I cannot do as you suggested David


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120894/new/

https://reviews.llvm.org/D120894



More information about the llvm-commits mailing list