[PATCH] D119880: [FuncSpec] Support function specialization across multiple arguments.

Alexandros Lamprineas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 10 05:41:50 PST 2022


labrinea added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/FunctionSpecialization.cpp:439
+      while (Specializations.size() > MaxClonesThreshold)
+        Specializations.erase(Specializations.begin());
+    } else {
----------------
SjoerdMeijer wrote:
> Can we just do a `return` after this, thus don't need the `else` and decrease indentation? 
We would like to print the debug info that follows. It's useful even when the cost model is disregarded.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119880/new/

https://reviews.llvm.org/D119880



More information about the llvm-commits mailing list