[PATCH] D121169: Cleanup codegen includes

serge via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 10 05:20:46 PST 2022


serge-sans-paille added a comment.

In D121169#3372471 <https://reviews.llvm.org/D121169#3372471>, @thakis wrote:

> Also breaks a small number of clang tests: http://45.33.8.238/linux/70644/step_7.txt
>
> Reverted in a278250b0f85949d4f98e641786e5eb2b540c6b0 <https://reviews.llvm.org/rGa278250b0f85949d4f98e641786e5eb2b540c6b0> for now.
>
> (Please run tests before landing changes, please look at the presubmit bot, please revert quickly when someone reports a problem so not many people have to re-analyze breakage, etc)

Thanks for reverting. I did run the build, but not the tests as they generally are not impacted by include change. On that step, some passes are not registered, which is odd. I'll investigate and update that diff.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121169/new/

https://reviews.llvm.org/D121169



More information about the llvm-commits mailing list