[PATCH] D121341: [SystemZ] implement adjustInliningThreshold()

Thu Mar 10 04:27:49 PST 2022

uweigand added inline comments.

================
Comment at: llvm/test/CodeGen/SystemZ/inline-thresh-adjust.ll:1
+; RUN: opt < %s -mtriple=systemz-unknown -mcpu=z15 -inline -disable-output \
+; RUN:   -debug-only=inline 2>&1 | FileCheck %s
----------------
jonpa wrote:
> This doesn't check that a particular function is actually inlined, but it can at least make sure that this type of function gets a boosted threshold, so maybe it could still be used, or?
> 
How stable are these particular numbers (1012, 1687)?  I don't think it would be a good idea to hard-code those in a test case if they change randomly with any codegen change?

If we want to test whether the function is inlined, can't we simply verify whether the function name symbol does not exist in the output (because the function was completely eliminated)?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121341/new/

https://reviews.llvm.org/D121341