[PATCH] D121137: [AArch64] Lower 3 and 4 sources buildvectors to TBL

[Sam Tebbs via Phabricator via llvm-commits]

samtebbs added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:9064
+    // Construct a mask for the tbl. We may need to adjust the index for type
+    // larger that i8.
+    SmallVector<unsigned, 16> Mask;
----------------
that -> than


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:9076
+        if (V.getOperand(0) == Sources[s].Vec) {
+          unsigned InputBase =
+              16 * s + V.getConstantOperandVal(1) *
----------------
This rather complex calculation could do with a comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121137/new/

https://reviews.llvm.org/D121137