[PATCH] D121182: Expose ScalarizerPass options to C++ (not just commandline)

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 10 01:22:07 PST 2022


bjope accepted this revision.
bjope added a comment.
This revision is now accepted and ready to land.

Just a few nits. But otherwise this LGTM.



================
Comment at: llvm/include/llvm/Transforms/Scalar/Scalarizer.h:38
 class ScalarizerPass : public PassInfoMixin<ScalarizerPass> {
+  ScalarizerPassOptions options;
+
----------------
nit: This pass use CamelCase for variable names.


================
Comment at: llvm/include/llvm/Transforms/Scalar/Scalarizer.h:43
+
+  void setScalarizeVariableInsertExtract(bool value) {
+    options.ScalarizeVariableInsertExtract = value;
----------------
nit: This pass use CamelCase for variable names.


================
Comment at: llvm/include/llvm/Transforms/Scalar/Scalarizer.h:46
+  }
+  void setScalarizeLoadStore(bool value) { options.ScalarizeLoadStore = value; }
 };
----------------
nit: This pass use CamelCase for variable names.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121182/new/

https://reviews.llvm.org/D121182



More information about the llvm-commits mailing list